Skip to content

Added a JSONPath tester tool - #1017

Merged
veler merged 4 commits into
dev/2.0from
dev/2.0-jsonpathtester
Jan 16, 2024
Merged

veler merged 4 commits into
dev/2.0from
dev/2.0-jsonpathtester

Conversation

@veler

@veler veler commented Jan 6, 2024 •

Copy link
Copy Markdown
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: #749

What is the new behavior?

Added a new tool dedicated to testing JSONPath.
Also, moved Regex Tester and XML Validator tools to a new Testers group.

Other information

image

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler veler added the devtoys-v2.0 DevToys v2.0 label Jan 6, 2024
@veler
veler requested a review from btiteux January 6, 2024 19:09
@veler veler linked an issue Jan 6, 2024 that may be closed by this pull request
Comment thread src/app/dev/DevToys.Tools/Helpers/XmlHelper.cs
Comment thread src/app/dev/DevToys.Tools/Helpers/JsonHelper.cs
@btiteux

btiteux commented Jan 8, 2024

Copy link
Copy Markdown
Collaborator

Hum quick thinking, should we keep the XML Validators in the same group or we could create a new Validators groups?

I think it's weird to have the XML Validators with the Testers.

@veler

veler commented Jan 9, 2024

Copy link
Copy Markdown
Collaborator Author

Hum quick thinking, should we keep the XML Validators in the same group or we could create a new Validators groups?

I think it's weird to have the XML Validators with the Testers.

Thanks for the suggestion. XML Validator, in the end, "tests" an XML against its XSD. How about renaming XML Validator to XML / XSD Tester or XML Tester ? What do you think @btiteux ?

@btiteux

btiteux commented Jan 9, 2024

Copy link
Copy Markdown
Collaborator

Ok we can rename the XML Validator for XML Tester.

No test for this tool?

@veler

veler commented Jan 13, 2024

Copy link
Copy Markdown
Collaborator Author

Ok we can rename the XML Validator for XML Tester.

Done !

No test for this tool?

There are tests for the helper, but I admit there aren't for the gui and command line.

@btiteux btiteux left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will approve this pull request but we really need to add Unit Test for the GUI

@veler veler mentioned this pull request Jan 16, 2024
@veler

veler commented Jan 16, 2024

Copy link
Copy Markdown
Collaborator Author

Thanks @btiteux , I just pushed a few more tests for UI and command line

@veler
veler merged commit 398d21b into dev/2.0 Jan 16, 2024
@veler
veler deleted the dev/2.0-jsonpathtester branch January 16, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devtoys-v2.0 DevToys v2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON path test

2 participants