Repository navigation
[SVLS-8350] Bump datadog-ci version and improve integration tests - #222
Conversation
|
To use Codex here, create a Codex account and connect to github. |
There was a problem hiding this comment.
Pull request overview
This PR updates the datadog-ci and AWS SDK dependencies to support newer runtimes (e.g., .NET 10, Java 25), and modifies the instrumentation logic to pass "none" for layer versions when not specified. It also enhances integration tests to properly validate all supported runtime layers and verify that unspecified layers are not added.
Changes:
- Updated datadog-ci packages from v4.4.0 to v5.4.0 and AWS SDK packages from v3.948.0 to v3.970.0
- Modified layer version handling to use "none" instead of undefined when versions are not specified
- Enhanced integration tests to check .NET, Ruby, and Java layers, and validate that unspecified layers are not added
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated datadog-ci and AWS SDK package versions; fixed typo in description |
| src/instrument.ts | Changed layer version handling to pass "none" instead of undefined with explicit type casting |
| test/instrument.test.ts | Updated test expectation to check for "none" instead of undefined |
| integration-tests/utilities/remote-config.ts | Added support for .NET, Ruby, and Java layer versions with conditional inclusion in config |
| integration-tests/utilities/is-function-instrumented.ts | Added checkLayer helper and extended runtime checks for .NET, Ruby, and Java |
| integration-tests/scheduled-events.test.ts | Added tests for undefined layer versions and new runtime versions (Java 25, .NET 10) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| l?.Environment?.Variables[varName] === value; | ||
|
|
||
| const checkLayer = ( | ||
| funConfig: any, |
There was a problem hiding this comment.
hmm i should probably see if i can slap a claude agent to improve the typing, we ideally shouldn't be using any if we can help it
What does this PR do?
This PR updates the version of datadog-ci and AWS SDKs. Bumping datadog-ci:
This PR also updates integration tests to:
Motivation
Supporting latest runtimes
Testing Guidelines
Integration tests are passing
Additional Notes