Repository navigation
Enable AOT Support - #312
Merged
Merged
Conversation
VladislavAntonyuk
approved these changes
Sep 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR enables Full AOT for
CommunityToolkit.Maui.Markupby adding<IsAotCompatible>true</IsAotCompatible>.PR Checklist
mainat time of PRAdditional information
This PR promotes all of the Trimmer + AOT analyzer warnings to errors in
<warningsaserrors>insideDirectory.Build.propsto ensure we don't accidentally inject non-AOT Safe code in future PRs.This PR also enables
<PublushAot>for Release builds ofCommunityToolkit.Maui.Markup.Sampleto ensure our sample continues to run nominally while using AOT and does not break in future releases.