[netfab]

This silence two compiler warnings (described in commit message).

[Nerixyz]

(described in commit message)

We use squash merges and usually take the description from the pull request, not the individual commit(s).

[pajlada]

Hi! Thanks for your contribution.

I'd prefer if this uses std::ignore. If there's a reason we should use [[maybe_unused]] instead, please enlighten me 🙏

[netfab]

I'd prefer if this uses std::ignore. If there's a reason we should use [[maybe_unused]] instead, please enlighten me 🙏

There's no particular reason, I've used it often lately, that's why I used it here.
In this context, the only difference I see is that using [[maybe_unused]] avoids to include an additional header.
Do you want me to make the change ?

[pajlada]

I'd prefer if this uses std::ignore. If there's a reason we should use [[maybe_unused]] instead, please enlighten me 🙏

There's no particular reason, I've used it often lately, that's why I used it here. In this context, the only difference I see is that using [[maybe_unused]] avoids to include an additional header. Do you want me to make the change ?

Yes please - thank you!

[pajlada]

Thank you! As a first-time contributor, you are now eligible to be listed in the About page in Chatterino.

If you want this, you can open a new PR where you modify the resources/contributors.txt file and add yourself to the list. Read the comments at the top for instructions.