Repository navigation
feat: add scaling setting for twitch gifs - #7315
Merged
Merged
Conversation
pajlada
requested changes
Oct 24, 2026
pajlada
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twitch gifs are currently displayed at a fixed size, which is somewhat smaller than on twitch web chat. This PR adds a
Twitch GIF sizesetting, which has an option to match twitch web chat's sizing (1.4x (Twitch)).Scaled twitch gifs now use smooth scaling because they look blocky without it. I did some profiling and this is not a performance concern. While spamming 10 gif messages per second, the average paint time without smooth scaling was 34 microseconds, and with smooth scaling it was 79 microseconds. It is over twice as long but still nowhere near the magnitude that we need to worry about, and the test was a deliberately extreme case.
I did also test smooth scaling for animated emotes, and I think it would be safe to use, but it is outside of the scope of this PR. In the same scenario at 12 animated emotes per message the paint time increased from 47 microseconds to 110 microseconds.