Repository navigation
fix: do not block Enter when the completion popup is empty - #7301
Merged
Merged
Conversation
…ion-menu # Conflicts: # src/widgets/splits/InputCompletionPopup.cpp # tests/src/InputCompletion.cpp # tests/src/SplitInput.cpp
pajlada
reviewed
Oct 18, 2026
Comment on lines
+173
to
+174
| if ((keyEvent->key() == Qt::Key_Enter || | ||
| keyEvent->key() == Qt::Key_Return) && |
Member
There was a problem hiding this comment.
A user can change the key binding for "send message", in which case the issue would not be fixed.
I haven't found a good way to figure out that a shortcut of a specific type was triggered, so I'm not sure if it's feasible to solve this
Contributor
Author
There was a problem hiding this comment.
This check is just for accepting a completion, the change in SplitInput already lets custom send hotkeys through when the completion list is empty
I added a test covering this case to be sure
pajlada
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
:and@completion popup remains open when there are no results. In that state, it consumesEnterbut does nothing.This was discussed in #1872, but the issue was closed after fixing only a problem with
:inside links.Fixed by only having the completion popup consume
Enterwhen there is a completion to accept. If the popup is empty,Enterfalls through to the normal input actions. That usually means sending the message, but can vary depending on the user's hotkeys.Added tests.