Repository navigation
fix: show inline twitch gif tooltips without link previews enabled - #7283
Merged
Merged
Conversation
Contributor
|
An issue with this is that we're now using the link resolver even though the user didn't enable it. |
Contributor
Author
Are we? As far as I can see the text comes from the twitch message's placeholder text, there's no link resolver request. |
Contributor
|
Oh, I thought this intends to show the tooltip when gifs aren't inline. |
Contributor
Author
|
No, apologies if my wording wasn't clear. Currently the tooltips only work if the link previews setting is enabled, even when the gif is displayed inline. I think inline gifs as images should show their tooltip like emotes do, and we already have the data for that. No change is made to gifs displayed as links. |
pajlada
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twitch gifs as images currently don't have a tooltip if link previews are disabled. This is contrary to how existing inline images (emotes) work in chat. You may want to see the name of the gif without also having link previews enabled.
Fixed by showing tooltips their regardless of the link previews setting, provided the gif is displayed as an inline image.
No change is made to gifs as links.