Repository navigation
chore: Add backup functionality to window layout - #7272
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pajlada
requested changes
Sep 13, 2026
| return window.geometry_; | ||
| return window.geometry_; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
If we have an error message here, maybe we can print that still
pajlada
approved these changes
Sep 13, 2026
pajlada
enabled auto-merge (squash)
September 13, 2026 11:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Someone on Discord mentioned that their window layout reset occasionally. We already have some backup restoration functionality for settings, so this PR uses that for the window layout. Most of this PR is switching to
ExpectedStrand passing the errors on.When parsing command line arguments, we also check the window layout for the initial bounds. But here I opted to not do restoration, as it's only a hint to where the window should be placed.