Repository navigation
fix: count message length in unicode codepoints - #7256
Merged
Merged
Conversation
pajlada
approved these changes
Sep 12, 2026
pajlada
left a comment
pajlada
left a comment
Member
There was a problem hiding this comment.
Works well in my testing.
Funnily enough, a wall of lions count as ascii art
pajlada
enabled auto-merge (squash)
September 12, 2026 10:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some emojis count twice towards the input length because
QString::length()is used, which counts UTF-16 code units rather than unicode codepoints.The indicator turns red and reads 500 when the input contains 250 of these, but twitch allows you to send 500.
Fixed by counting unicode codepoints instead.