Repository navigation
fix: Crash when releasing only split in container - #7255
Merged
Merged
Conversation
pajlada
approved these changes
Sep 8, 2026
pajlada
enabled auto-merge (squash)
September 8, 2026 21:19
babicekmarek
pushed a commit
to babicekmarek/streamally-chatterino
that referenced
this pull request
Sep 14, 2026
Found this when testing Chatterino#7254 - if you compile with a hardened/debug STL and close the only split in a container, there will be an assertion failure when trying to access `back()` of an empty vector. We never access that pointer, but are still calling the function. Reviewed-by: pajlada <rasmus.karlsson@pajlada.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this when testing #7254 - if you compile with a hardened/debug STL and close the only split in a container, there will be an assertion failure when trying to access
back()of an empty vector. We never access that pointer, but are still calling the function.Steps to reproduce: