Repository navigation
fix: round start offset when painting messages - #7241
Merged
Merged
Conversation
pajlada
approved these changes
Sep 12, 2026
pajlada
enabled auto-merge (squash)
September 12, 2026 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This intends to fix the small jumping when resizing a channel view (#7240 (comment)).
We're always rounding the y-position to ensure that the text stays sharp and doesn't blend between two pixels. But when resizing the window, precision loss somewhere may lead to us being slightly above/below a whole number (e.g. 1.001 → 0.9998).
Rounding doesn't always fix this (we could just shift by 0.5 and have a similar issue). My assumption is that we're always close to a whole number, so rounding will yield the correct result.
Reproducing this depends on the messages in the view, the font, and the font engine. So you may have to experiment a bit.