Skip to content

fix: make selecting non-text elements easier - #7232

Merged
pajlada merged 3 commits into
Chatterino:masterfrom
4rneee:fix/select-emotes
Sep 6, 2026
Merged

pajlada merged 3 commits into
Chatterino:masterfrom
4rneee:fix/select-emotes

Conversation

@4rneee

@4rneee 4rneee commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

This improves selecting emotes and other non-text elements. Previously you had to drag the mouse all the way to the end of the emote to select it. The cutoff is now the center of the element. The difference is especially noticeable when selecting from right to left.

Since the code is the same for all elements (except TextLayoutElement), we could maybe move it to MessageLayoutElement but I wasn't too sure about this.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread src/messages/layouts/MessageLayoutElement.cpp Outdated
Comment thread src/messages/layouts/MessageLayoutElement.cpp Outdated
Comment thread src/messages/layouts/MessageLayoutElement.cpp Outdated
Comment thread src/messages/layouts/MessageLayoutElement.cpp Outdated
@pajlada
pajlada enabled auto-merge (squash) September 6, 2026 09:16
@pajlada
pajlada merged commit 39f0e8b into Chatterino:master Sep 6, 2026
18 checks passed
babicekmarek pushed a commit to babicekmarek/streamally-chatterino that referenced this pull request Sep 14, 2026
This improves selecting emotes and other non-text elements. Previously
you had to drag the mouse all the way to the end of the emote to select
it. The cutoff is now the center of the element. The difference is
especially noticeable when selecting from right to left.

Reviewed-by: pajlada <rasmus.karlsson@pajlada.com>
@4rneee
4rneee deleted the fix/select-emotes branch September 14, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants