Repository navigation
fix: show streamlink message in selected window - #7231
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ->getMainWindow() | ||
| .getNotebook() | ||
| .getSelectedPage()); | ||
| SplitContainer *currentPage = getApp() |
Contributor
There was a problem hiding this comment.
warning: pointee of variable 'currentPage' of type 'SplitContainer *' can be declared 'const' [misc-const-correctness]
Suggested change
| SplitContainer *currentPage = getApp() | |
| SplitContainer const*currentPage = getApp() |
Contributor
|
I think this PR itself is fine, but I do wonder what we should do if Chatterino is embedded. There, we still create a main window, but that's not shown. Maybe there should be a last selected split? |
pajlada
approved these changes
Sep 6, 2026
pajlada
enabled auto-merge (squash)
September 6, 2026 10:13
babicekmarek
pushed a commit
to babicekmarek/streamally-chatterino
that referenced
this pull request
Sep 14, 2026
Reviewed-by: pajlada <rasmus.karlsson@pajlada.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the message was always shown in the main window, even when opening something in streamlink while focusing a popup.