[kostadinsh]

WebSocketPool.hpp and VectorMessageSink.hpp use std::vector, but don't include <vector> which causes a build failure with libc++ 23 since it's dropping a lot of transitive includes.

In file included from src/controllers/plugins/api/WebSocket.cpp:5:
In file included from src/controllers/plugins/api/WebSocket.hpp:8:
src/common/websockets/WebSocketPool.hpp:76:5: error: no template named 'vector' in namespace 'std'; did you mean 'QVector'?
   76 |     std::vector<std::pair<std::string, std::string>> headers;
      |     ^~~~~~~~~~~
      |     QVector
/usr/include/qt6/QtCore/qcontainerfwd.h:40:22: note: 'QVector' declared here
   40 | template<typename T> using QVector = QList<T>;
      |                     

In file included from src/util/VectorMessageSink.cpp:5:
src/util/VectorMessageSink.hpp:34:16: error: no template named 'vector' in namespace 'std'
   34 |     const std::vector<MessagePtr> &messages() const;
      |           ~~~~~^
src/util/VectorMessageSink.hpp:35:10: error: no template named 'vector' in namespace 'std'
   35 |     std::vector<MessagePtr> takeMessages() &&;
      |     ~~~~~^
src/util/VectorMessageSink.hpp:38:10: error: no template named 'vector' in namespace 'std'
   38 |     std::vector<MessagePtr> messages_;
      |     ~~~~~^

See also: https://discourse.llvm.org/t/rfc-remove-unused-transitive-includes-from-the-libc-headers/90157

[pajlada]

Awesome, thanks!

[Wissididom]

Thank you! As a first-time contributor, you are now eligible to be listed in the About page in Chatterino.

If you want this, you can open a new PR where you modify the resources/contributors.txt file and add yourself to the list. Read the comments at the top for instructions.