Repository navigation
fix: clear optional image uploader settings on import - #7225
Merged
pajlada merged 3 commits intoSep 5, 2026
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
pajlada
approved these changes
Sep 5, 2026
pajlada
enabled auto-merge (squash)
September 5, 2026 10:15
babicekmarek
pushed a commit
to babicekmarek/streamally-chatterino
that referenced
this pull request
Sep 14, 2026
Importing an image uploader configuration does not replace `Headers` or `DeletionURL` when the imported configuration provides no values for them. This can cause an auth header from the previous config to be sent to the newly imported host. Fixed by clearing optional uploader settings when they are not provided by the imported config Reviewed-by: pajlada <rasmus.karlsson@pajlada.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing an image uploader configuration does not replace
HeadersorDeletionURLwhen the imported configuration provides no values for them. This can cause an auth header from the previous config to be sent to the newly imported host.Fixed by clearing optional uploader settings when they are not provided by the imported config
Added a test covering this
Steps to reproduce:
Authorization: Bearer ugandan-keyand a deletion url{ "Version": "1.0.0", "RequestURL": "https://old.example/upload", "FileFormName": "file", "URL": "{response}", "DeletionURL": "https://old.example/delete/{delete-key}", "Headers": { "Authorization": "Bearer ugandan-key" } }HeadersandDeletionURL{ "Version": "1.0.0", "RequestURL": "https://new.example/upload", "FileFormName": "file", "URL": "{response}" }