Skip to content

ci: use official download-artifact action - #6954

Merged
pajlada merged 4 commits into
Chatterino:masterfrom
kill74:ci/use-official-download-artifact
Aug 22, 2026
Merged

pajlada merged 4 commits into
Chatterino:masterfrom
kill74:ci/use-official-download-artifact

Conversation

@kill74

@kill74 kill74 commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Fixes #6682.

Summary

This PR replaces dawidd6/action-download-artifact in the installer workflow with the official actions/download-artifact action.

The workflow now handles both ways the installer workflow can be started:

  • For workflow_run, it downloads the artifact from the triggering Build workflow run.
  • For workflow_dispatch, it uses actions/github-script to find a successful Build workflow run for the current commit, then downloads the artifact from that run.

The artifact name and download path are kept unchanged.

Testing

I verified the workflow changes manually by checking that:

  • The installer workflow still downloads chatterino-windows-x86-64-Qt-${{ matrix.qt-version }}.zip.
  • The artifact is still downloaded into build/.
  • The manual workflow_dispatch path keeps the previous commit-based lookup behavior.

The full workflow behavior should be validated by GitHub Actions once this PR runs.

@pajlada pajlada left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've included changes from your other PR

@kill74
kill74 requested a review from pajlada April 27, 2026 16:11
@kill74
kill74 force-pushed the ci/use-official-download-artifact branch from 6dbdde3 to 7c295c2 Compare April 27, 2026 16:15
@kill74

kill74 commented Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, that was my mistake. I cleaned up the branch so this PR now only contains the installer workflow change.

Comment thread .github/workflows/create-installer.yml Outdated
@pajlada
pajlada enabled auto-merge (squash) August 22, 2026 10:00
@pajlada
pajlada merged commit 986f234 into Chatterino:master Aug 22, 2026
18 checks passed
invisibl3cat pushed a commit to invisibl3cat/chatterino2 that referenced this pull request Aug 23, 2026
Reviewed-by: Nerixyz <nerixdev@outlook.de>
Reviewed-by: pajlada <rasmus.karlsson@pajlada.com>
babicekmarek pushed a commit to babicekmarek/streamally-chatterino that referenced this pull request Sep 14, 2026
Reviewed-by: Nerixyz <nerixdev@outlook.de>
Reviewed-by: pajlada <rasmus.karlsson@pajlada.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: investigate github script + actions/download-artifact usability

3 participants