Skip to content

fix: add missing ellipsis to menu items that open dialogs - #6858

Merged
pajlada merged 5 commits into
Chatterino:masterfrom
voiceofgrog:fix/ellipsis-in-menu-items
Aug 2, 2026
Merged

pajlada merged 5 commits into
Chatterino:masterfrom
voiceofgrog:fix/ellipsis-in-menu-items

Conversation

@voiceofgrog

Copy link
Copy Markdown
Contributor

Added missing ellipsis (…) to menu items that open a dialog requiring user input,
following standard HIG conventions.

The following menu items were updated:

  • "Search…" in the split context menu (SplitHeader.cpp)
  • "Set filters…" in the split context menu (SplitHeader.cpp)
  • "Rename Tab…" in the tab context menu (NotebookTab.cpp)

Fixes #4969.

Testing steps

  1. Right-click any split header (or click the ⋮ kebab menu)
  2. Confirm "Search…" and "Set filters…" show with ellipsis
  3. Right-click any tab
  4. Confirm "Rename Tab…" shows with ellipsis
  5. Confirm no other menu items were unintentionally changed

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread src/widgets/helper/NotebookTab.cpp Outdated
@voiceofgrog
voiceofgrog force-pushed the fix/ellipsis-in-menu-items branch from 62975a1 to 1dfb37b Compare March 20, 2026 00:54
@pajlada
pajlada enabled auto-merge (squash) August 2, 2026 10:39
@pajlada
pajlada merged commit f6be300 into Chatterino:master Aug 2, 2026
18 checks passed
@pajlada

pajlada commented Aug 2, 2026

Copy link
Copy Markdown
Member

Thank you! As a first-time contributor, you are now eligible to be listed in the About page in Chatterino.

If you want this, you can open a new PR where you modify the resources/contributors.txt file and add yourself to the list. Read the comments at the top for instructions.

babicekmarek pushed a commit to babicekmarek/streamally-chatterino that referenced this pull request Sep 14, 2026
…#6858)

Added missing ellipsis (…) to menu items that open a dialog requiring
user input,
following standard HIG conventions.

Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
Tested-by: voiceofgrog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Ellipsis in Menu Items

2 participants