Skip to content

Added support for percent-encoded url for custom player - #6725

Merged
pajlada merged 5 commits into
Chatterino:masterfrom
SonicSegFault:feature/custom-player-uri-encoding
Jan 10, 2026
Merged

pajlada merged 5 commits into
Chatterino:masterfrom
SonicSegFault:feature/custom-player-uri-encoding

Conversation

@SonicSegFault

Copy link
Copy Markdown
Contributor

This PR updates openInCustomPlayer to percent‑encode Twitch URLs before embedding them in a custom URI scheme.

Possible solution to Issue:#6635

Comment thread src/util/CustomPlayer.cpp Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread src/util/CustomPlayer.cpp Outdated
@pajlada
pajlada enabled auto-merge (squash) January 10, 2026 12:04
@pajlada
pajlada merged commit af57348 into Chatterino:master Jan 10, 2026
19 checks passed
@pajlada

pajlada commented Jan 10, 2026

Copy link
Copy Markdown
Member

Thank you! As a first-time contributor, you are now eligible to be listed in the About page in Chatterino.

If you want this, you can open a new PR where you modify the resources/contributors.txt file and add yourself to the list. Read the comments at the top for instructions.

@pajlada pajlada mentioned this pull request Jan 10, 2026
4 tasks done
babicekmarek pushed a commit to babicekmarek/streamally-chatterino that referenced this pull request Sep 14, 2026
Reviewed-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants