Skip to content

fix: disable sortTabsAlphabetically when notebook layout locked (#6704) - #6710

Merged
pajlada merged 3 commits into
Chatterino:masterfrom
ruinivist:sort-when-locked
Jan 5, 2026
Merged

pajlada merged 3 commits into
Chatterino:masterfrom
ruinivist:sort-when-locked

Conversation

@ruinivist

Copy link
Copy Markdown
Contributor

Greys out the "Sort Tabs Alphabetically" option if the tabs are locked.

  • the assert should help ensure not being locked as a precondition
  • this handles disabling for the click event for locking layout as well as the first initialization of menu if it's locked already from settings
image

first pr FeelsStrongMan

@pajlada pajlada left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just these nits, and as extra credit you can move the definition of sortTabsAlphabetically() into the protected: scope in the header file

Comment thread src/widgets/Notebook.cpp Outdated
Comment thread CHANGELOG.md Outdated
@ruinivist
ruinivist requested a review from pajlada January 5, 2026 20:26
@pajlada
pajlada enabled auto-merge (squash) January 5, 2026 21:55
@pajlada
pajlada disabled auto-merge January 5, 2026 21:55
@pajlada
pajlada enabled auto-merge (squash) January 5, 2026 21:56
@pajlada pajlada linked an issue Jan 5, 2026 that may be closed by this pull request
4 tasks done
@pajlada
pajlada merged commit 6110c32 into Chatterino:master Jan 5, 2026
19 checks passed
@pajlada

pajlada commented Jan 5, 2026

Copy link
Copy Markdown
Member

Thank you! As a first-time contributor, you are now eligible to be listed in the About page in Chatterino.

If you want this, you can open a new PR where you modify the resources/contributors.txt file and add yourself to the list. Read the comments at the top for instructions.

babicekmarek pushed a commit to babicekmarek/streamally-chatterino that referenced this pull request Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sort Tabs Alphabetically still works when Lock Tab Layout is on

2 participants