Skip to content

refactor: simplify uses of getMessageSnapshot - #6607

Merged
pajlada merged 5 commits into
Chatterino:masterfrom
Nerixyz:refactor/simplify-snapshot-processing
Nov 29, 2025
Merged

refactor: simplify uses of getMessageSnapshot#6607
pajlada merged 5 commits into
Chatterino:masterfrom
Nerixyz:refactor/simplify-snapshot-processing

Conversation

@Nerixyz

@Nerixyz Nerixyz commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

Some use of getMessageSnapshot can be simplified.

  • Going through the messages in reverse can use std::views::reverse.
  • Iterating through all messages can use a range-for loop.
  • Only accessing the last message can use last from LimitedQueue.

@pajlada
pajlada enabled auto-merge (squash) November 29, 2025 11:04
@pajlada
pajlada merged commit 041674b into Chatterino:master Nov 29, 2025
18 checks passed
babicekmarek pushed a commit to babicekmarek/streamally-chatterino that referenced this pull request Sep 14, 2026
@Nerixyz
refactor: simplify uses of getMessageSnapshot (Chatterino#6607)
1c28793 
Reviewed-by: pajlada <rasmus.karlsson@pajlada.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pajlada pajlada pajlada approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Nerixyz @pajlada