Skip to content

fix: add Unicode license - #6579

Merged
pajlada merged 1 commit into
masterfrom
chore/license-clarification-2
Nov 14, 2025
Merged

pajlada merged 1 commit into
masterfrom
chore/license-clarification-2

Conversation

@pajlada

@pajlada pajlada commented Nov 14, 2025

Copy link
Copy Markdown
Member

No description provided.

@Nerixyz

Nerixyz commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

Where do we use Unicode directly? We don't directly depend on icu and the emoji data license is already included.

If we were to include all transitive licenses, we'd also need to include something like zlib which is one of Qt's dependencies.

@pajlada

pajlada commented Nov 14, 2025

Copy link
Copy Markdown
Member Author

Where do we use Unicode directly? We don't directly depend on icu and the emoji data license is already included.

If I understand things correctly, we need to include licenses for anything we include statically in our program. This includes Unicode since emoji-data's json blob is based off of Unicode data.
I think we would be fine if the emoji-data license already contained the Unicode license blurb, but since it doesn't I added it as a standalone inclusion.

If we were to include all transitive licenses, we'd also need to include something like zlib which is one of Qt's dependencies.

This is not what I'm aiming to do. If someone with more open source legal requirements can provide more insight on what we should and should not do, I'll follow those directions.

@Nerixyz

Nerixyz commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

If I understand things correctly, we need to include licenses for anything we include statically in our program.

Thank you, this would be a great description.

@pajlada
pajlada merged commit b637029 into master Nov 14, 2025
20 checks passed
@pajlada
pajlada deleted the chore/license-clarification-2 branch November 14, 2025 20:27
Pietro228 pushed a commit to Stream-Ally/streamally-chatterino that referenced this pull request Dec 5, 2025
babicekmarek pushed a commit to babicekmarek/streamally-chatterino that referenced this pull request Sep 14, 2026
babicekmarek pushed a commit to babicekmarek/streamally-chatterino that referenced this pull request Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants