Repository navigation
fix: overflow when computing scrollbar rect - #6547
Merged
Merged
Conversation
pajlada
approved these changes
Oct 21, 2025
pajlada
enabled auto-merge (squash)
October 21, 2025 15:00
Contributor
|
Changelog: |
Pietro228
pushed a commit
to Stream-Ally/streamally-chatterino
that referenced
this pull request
Dec 5, 2025
Co-authored-by: Kasia <zneix@zneix.eu>
Pietro228
pushed a commit
to Stream-Ally/streamally-chatterino
that referenced
this pull request
Dec 5, 2025
Co-authored-by: Kasia <zneix@zneix.eu>
babicekmarek
pushed a commit
to babicekmarek/streamally-chatterino
that referenced
this pull request
Sep 14, 2026
Co-authored-by: Kasia <zneix@zneix.eu>
babicekmarek
pushed a commit
to babicekmarek/streamally-chatterino
that referenced
this pull request
Sep 14, 2026
Co-authored-by: Kasia <zneix@zneix.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
maximum <= minimum, then we would divide by0.0000001. This could result in values for the y-position and height of the scrollbar rectangle that don't fit into a 32-bit signed integer. Consider the following:currentValue_ = 800,pageSize_ = 20,trackHeight_ = 500maximum_andminimum_get set to 0 (while the rest stays as is)The difference between
maximumandminimumis the number of messages currently in the channel. With this PR, we assume there's always at least one message when calculating the thumb rect. If there are no messages in a channel, we'll have an incorrect rect, but this won't be shown, because the scrollbar is always hidden in that case.I updated the documentation of
Scrollbarto better indicate the values and meaning ofminimumand other members.