Repository navigation
fix: set Qt definitions PUBLIC in chatterino-lib/-version - #6520
Merged
Merged
Conversation
pajlada
approved these changes
Oct 4, 2025
pajlada
enabled auto-merge (squash)
October 5, 2025 10:13
babicekmarek
pushed a commit
to babicekmarek/streamally-chatterino
that referenced
this pull request
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
-DQT_DISABLE_DEPRECATED_BEFORE=xxx -DQT_WARN_DEPRECATED_UP_TO=xxx -DQT_NO_KEYWORDSdefinitions are only set forchatterino-libandchatterino-version. However, they should also be set forchatterino-testandchatterino-benchmark, since these projects consume headers from Chatterino. EspeciallyQT_NO_KEYWORDSshould match.This PR does that by using
target_compile_definitions(xxx PUBLIC flags...).