Repository navigation
fix: image uploader setting import - #6387
Conversation
Yes, we do want to be ShareX compatible - we even advertise this. In #6394 I added some test for this, because there were none. Once this gets merged, you can add more tests here and update the snapshots (change |
|
If you could fix the tests to update the "new reality" that'd be great. |
|
Will do so when available |
|
Somewhat unrelated: in In |
|
Thank you @x3rt! As a first-time contributor, you are now eligible to be listed in the About page in Chatterino. If you want this, you can open a new PR where you modify the |
Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
\nnewline character, instead of the expected;semicolon causing uploads to use invalid headersURLandDeletionURLsettings would store the raw string meaning ShareX's{response}or{json:files[0].url}would be stored as such and thereforegetLinkFromResponsewould not parse the response correctly.This PR attempts to fix the above.
As this is my first time working with Chatterino's code I expect there to be things to nit-pick about my changes. I did attempt my best to follow the Contributing guidelines & match the format of other functions.
Some things to note;