Repository navigation
Adding option to customize log file timestamps. - #6338
Conversation
| BoolSetting customLogTimestamp = { | ||
| "/appearance/messages/customLogTimestamp", false}; |
There was a problem hiding this comment.
Bikeshed: This isn't really a custom timestamp. It's more like that the timestamp format is inherited. Wouldn't it be better to turn this into a string, so it's fully customizable and independent of the chat timestamp format?
There was a problem hiding this comment.
I wanted to follow the existing dropdown example for simplicity and uniformity, but would be fine with any changes.
I think my preference would be to either change the wording to more closely match "inherited" or adding a separate dropdown in the moderation/logs settings dialog. If a simple text box is prefered I can also make that change, but it is less user friendly in my view.
There was a problem hiding this comment.
After looking at this a bit more, there are complications from the chat timestamp display option as well, I will refactor.
There was a problem hiding this comment.
I refactored this to two dropdowns to allow the message timestamp format and log timestamp format to differ, let me know what you think.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pajlada
left a comment
pajlada
left a comment
There was a problem hiding this comment.
Just some small nits wrt formatting & its default value, overall this looks good to me
|
I'm on my phone, so I can't check the settings myself. But it looks to me like the log timestamp doesn't really fit into the messages section of the settings. It's not related to the messages that get displayed in the chat. Is there maybe a log section that this could fit in? |
Yup! Under the moderation sidebar, under the Logs tab #6338 (comment) |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: pajlada <rasmus.karlsson+github@pajlada.com>
Co-authored-by: pajlada <rasmus.karlsson+github@pajlada.com>
19738ff to
7117c17
Compare
|
Thank you @droidicus! As a first-time contributor, you are now eligible to be listed in the About page in Chatterino. If you want this, you can open a new PR where you modify the |
This PR adds an option to change the formatting of the log file timestamps:
The option is
hh:mm:aaby default to preserve the previous behavior.The log file format changes when the options are changes:
