Repository navigation
refactor(liveupdates): use WebSocketPool over websocketpp - #6308
Merged
Merged
Conversation
Nerixyz
commented
Jun 29, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
|
At a quick glance this looks nice. I will take a more proper look when |
Nerixyz
marked this pull request as ready for review
October 7, 2025 17:34
pajlada
reviewed
Nov 1, 2025
pajlada
reviewed
Nov 2, 2025
pajlada
reviewed
Nov 2, 2025
pajlada
left a comment
pajlada
left a comment
Member
There was a problem hiding this comment.
shortName_ is currently unused - you can forward it to the pool for use in thread name if you'd like, no requirement for this PR
pajlada
reviewed
Nov 2, 2025
pajlada
approved these changes
Nov 8, 2025
pajlada
enabled auto-merge (squash)
November 8, 2025 12:09
babicekmarek
pushed a commit
to babicekmarek/streamally-chatterino
that referenced
this pull request
Sep 14, 2026
…no#6308) Reviewed-by: pajlada <rasmus.karlsson@pajlada.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The big goal is to get rid of websocketpp in the future and use Boost.Beast exclusively.
This PR moves the live-updates (BTTV and 7TV) to use the WebSocketPool initially added for plugins. This mixes up the design of the live-updates manager and client a bit.
QObjectto be able to guardQTimers (for reconnect backoff and heartbeats on 7TV).This is a draft because I added
onOpenwhich I want to add separately.