[knobby-tires]

Adds import/export functionality for image uploader settings as requested in #6283.

[pajlada]

Hi!
At a quick glance through the code, things look good. I'll give it a proper review & test this weekend.
Thanks for your contribution!

[knobby-tires]

Awesome! I am leaving town this weekend and will have very limited access to a computer. I am happy to make necessary adjustments when/if I can. Just want to make sure you know I am not abandoning the PR lol.

[pajlada]

As a first pass - will do another more in-depth review once it's more testable

When I was reviewing this I was noticing the text fields don't update when the setting updates from external sources - I've fixed that in another PR. So when you merge your PR with our main branch that'll be fixed.

[knobby-tires]

Hi @pajlada, I believe I addressed most of what you asked :

• I moved import/export functions to ImageUploader.hpp/cpp in the chatterino::imageuploader::detail namespace
• I changed exportSettings to take Settings &s parameter as suggested: QJsonObject exportSettings(Settings &s);
• I moved all related functions (importSettings, validateImportJson, parseAndApplyHeaders) to the new file
• Updated ExternalToolsPage to use the new functions
• Added the new files to CMakeLists.txt
• Confirmed functionality still works correctly (export/import both working)

Next I'll work on writing unit tests for the exportSettings function next

Thanks for the detailed feedback, if I have misunderstood anything up until now please let me know. I am really trying to learn and gain real experience here.

[github-actions]

clang-tidy made some suggestions

[pajlada]

File structure looks good from my perspective.
Some nits with how functions are structured, some documentation, and some questions regarding validation.

[github-actions]

clang-tidy made some suggestions

[pajlada]

This looks good to me now - I took the liberty of doing a few minor modifications.
Could you take a look at the changes I made and see if they make sense to you @knobby-tires ?

[knobby-tires]

@pajlada, Looks good to me! Thanks for the help.

[pajlada]

Thank you @knobby-tires! As a first-time contributor, you are now eligible to be listed in the About page in Chatterino.

If you want this, you can open a new PR where you modify the resources/contributors.txt file and add yourself to the list. Read the comments at the top for instructions.