Repository navigation
refactor: move Notebook enums to their own file - #6220
Merged
Merged
Conversation
All of Notebook.hpp was included in Settings.hpp. That also included a ton of Qt Gui stuff through BaseWidget.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| namespace chatterino { | ||
|
|
||
| enum NotebookTabLocation { Top = 0, Left = 1, Right = 2, Bottom = 3 }; |
Contributor
There was a problem hiding this comment.
warning: enum 'NotebookTabLocation' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]
enum NotebookTabLocation { Top = 0, Left = 1, Right = 2, Bottom = 3 };
^| enum NotebookTabLocation { Top = 0, Left = 1, Right = 2, Bottom = 3 }; | ||
|
|
||
| // Controls the visibility of tabs in this notebook | ||
| enum NotebookTabVisibility : int { |
Contributor
There was a problem hiding this comment.
warning: enum 'NotebookTabVisibility' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]
enum NotebookTabVisibility : int {
^
babicekmarek
pushed a commit
to babicekmarek/streamally-chatterino
that referenced
this pull request
Sep 14, 2026
Co-authored-by: Mm2PL <miau@mail.kotmisia.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #6162