Repository navigation
refactor(notebook): merge top/bottom and left/right layout - #6215
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
|
I could fix those, but I feel like it's better to do in another PR. |
pajlada
approved these changes
May 18, 2025
pajlada
enabled auto-merge (squash)
May 18, 2025 09:41
babicekmarek
pushed a commit
to babicekmarek/streamally-chatterino
that referenced
this pull request
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #6153.
Should make it easier to implement refactorings to notebook layout (and potentially fix the issues linked in #6153 (comment)).
Top/bottom and left/right layouts are almost the same, except for the direction. Unfortunately, they're not that similar, but we can still put them together and get the same result. The functions are named horizontal for left-to-right/right-to-left layout and vertical for top-to-bottom layout.
The easiest way to test this is to make screenshots and use the "difference" blend-mode in your favorite photo editor (tbf, all I did was diff the branches and insert an
ifwhere they differed). One small difference is that the custom buttons will show 1dip higher in the bottom layout. I don't think this is a major issue.I sneaked in some
static_casts in place of C-casts.