Skip to content

attempt to fix crashes on exit - #6187

Merged
pajlada merged 24 commits into
masterfrom
fix/eventapi-crash-random-on-exit
May 17, 2025
Merged

pajlada merged 24 commits into
masterfrom
fix/eventapi-crash-random-on-exit

Conversation

@pajlada
pajlada force-pushed the fix/eventapi-crash-random-on-exit branch from 5cab757 to 1d783b4 Compare May 4, 2025 12:38

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread src/Application.cpp
Comment thread src/Application.cpp Outdated
Comment thread src/providers/twitch/TwitchIrcServer.cpp
@pajlada
pajlada force-pushed the fix/eventapi-crash-random-on-exit branch 4 times, most recently from ad6fd45 to 23adedd Compare May 7, 2025 06:00
Comment thread CMakeLists.txt Outdated
@pajlada
pajlada force-pushed the fix/eventapi-crash-random-on-exit branch 4 times, most recently from c9f88be to 9733515 Compare May 10, 2025 13:24

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread src/providers/twitch/TwitchIrcServer.cpp Outdated
@pajlada
pajlada force-pushed the fix/eventapi-crash-random-on-exit branch 10 times, most recently from 0628ce6 to 54c0460 Compare May 17, 2025 10:26

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread src/Application.cpp
Comment thread src/Application.cpp
@pajlada
pajlada force-pushed the fix/eventapi-crash-random-on-exit branch 4 times, most recently from b266406 to 12cd541 Compare May 17, 2025 10:48

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread src/Application.cpp
Comment thread src/messages/Image.cpp Outdated
pajlada added 19 commits May 17, 2025 13:21
consumers can check if they should bother doing certain things if we're
quitting anyway
                   This also sets a STOPPED atomic bool we can use for
                   easier debugging if something gets called after stop
                   has been initiated
                  this change might not be necessary if we don't call
                  any callbacks from network
                         this ensures we don't try to destruct it after
                         the rest of our application has stopped
@pajlada
pajlada force-pushed the fix/eventapi-crash-random-on-exit branch 2 times, most recently from 2964425 to a022e9d Compare May 17, 2025 11:28

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread src/Application.cpp
@pajlada
pajlada marked this pull request as ready for review May 17, 2025 11:44
@pajlada

pajlada commented May 17, 2025

Copy link
Copy Markdown
Member Author

image

@pajlada
pajlada merged commit 6b968a1 into master May 17, 2025
@pajlada
pajlada deleted the fix/eventapi-crash-random-on-exit branch May 17, 2025 12:22
babicekmarek pushed a commit to babicekmarek/streamally-chatterino that referenced this pull request Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants