Repository navigation
fix: don't include blocked users in join/part messages - #6181
Merged
pajlada merged 5 commits intoMay 3, 2025
Merged
Conversation
Because we don't get the user's ID as part of a JOIN or PART message, we now store a set of Twitch User Logins to match against. This is the largest part of this change
Nerixyz
suggested changes
May 2, 2025
iProdigy
reviewed
May 2, 2025
pajlada
deleted the
fix/dont-include-blocked-users-in-join-or-part-messages
branch
May 3, 2025 09:32
babicekmarek
pushed a commit
to babicekmarek/streamally-chatterino
that referenced
this pull request
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users who are blocked no longer show up in the "Users joined:" or "Users parted:" messages
Fixes #2505
The biggest chunk of code of this fix comes from adding user logins to the list of blocks. There are some container types that allow for use of multiple keys (basically keeping the same type of logic we use with multiple sets but internally instead), but that seemed a bit out of scope of this change.