Repository navigation
fix: don't include .inc in outputs - #6154
Merged
Merged
Conversation
pajlada
approved these changes
Apr 16, 2025
babicekmarek
pushed a commit
to babicekmarek/streamally-chatterino
that referenced
this pull request
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling after a
ninja cleancaused the JSON generator to fail. This isn't a complete fix, the root of the problem is a bit deeper, because we'd actually need to split the task into two - one for generating the.incfile and one for generating the implementation, because clang will freak out if the.incfile doesn't exist and will refuse to resolve types likestd::chrono::system_clock1.Because we don't add new eventsub topics every day, it's fine having to recompile twice. Not being able to do clean the output is a bit worse, I think.
Footnotes
Ok, actually, it's a bit more complicated. The two-step process would work because we generally don't need the type information to generate a forward declaration, but in theory, it still reads an incomplete header so if type information would alter the names of generated types, this would be wrong. ↩