Skip to content

fix: receive bttv live updates again - #6132

Merged
pajlada merged 6 commits into
Chatterino:masterfrom
iProdigy:fix/bttv-ws
Apr 6, 2025
Merged

pajlada merged 6 commits into
Chatterino:masterfrom
iProdigy:fix/bttv-ws

Conversation

@iProdigy

@iProdigy iProdigy commented Apr 6, 2025 •

Copy link
Copy Markdown
Contributor

bttv socket server changed at some point to only support TLS 1.3 but we previously maxed at TLS 1.2 so the bttv ws stopped connecting due to a tls handshake error

I've tested that 7tv ws (supports tls 1.0-1.3) still works with this change (out of paranoia I disabled tls 1.0 & 1.1, which are both deprecated)

also updates outdated broadcast_me payload: https://betterttv.com/developers/websocket#user-broadcast

@iProdigy
iProdigy marked this pull request as ready for review April 6, 2025 08:36
Comment thread src/providers/liveupdates/BasicPubSubManager.hpp Outdated
Comment thread src/providers/liveupdates/BasicPubSubManager.hpp Outdated

@pajlada pajlada left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@pajlada
pajlada enabled auto-merge (squash) April 6, 2025 09:26
@pajlada
pajlada merged commit d8ef52a into Chatterino:master Apr 6, 2025
@iProdigy
iProdigy deleted the fix/bttv-ws branch April 6, 2025 17:03
babicekmarek pushed a commit to babicekmarek/streamally-chatterino that referenced this pull request Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants