[jacob-thompson]

fixes #2688

the paused chat indicator in its current form is a little bit difficult to see. I am suggesting:

• adding an outline so that the indicator stands out from other widget elements such as chat timestamps
• moving the indicator to the bottom of the widget since users' eyes are more likely to be focused on the bottom half of the widget than the top half of the widget
• adding "Chat Paused" text next to the symbol to make the indicator bigger and easier to notice

screenshots

before

after (dark theme)

after (black theme)

after (light theme)

after (white theme)

[github-actions]

clang-tidy made some suggestions

[github-actions]

warning: narrowing conversion from 'int' to 'float' [bugprone-narrowing-conversions]

        const auto pausedY = widgetHeight - a - 5;
                             ^

[github-actions]

warning: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions]

        font.setPixelSize(a);
                          ^

[github-actions]

warning: narrowing conversion from 'int' to 'float' [bugprone-narrowing-conversions]

                        QRectF(textX + dx, pausedY + dy, textWidth, a),
                                                     ^

[Nerixyz]

I don't think the indicator should be at the bottom. Considering we have "Pause chat on hover", users likely want to read the last messages. Imo, an outline around the pause icon should be fine. Or maybe just the string "paused".

[iProdigy]

Could you experiment with a red outline around the pause icon (and no text)?

[jacob-thompson]

Imo, an outline around the pause icon should be fine. Or maybe just the string "paused".

I think if anything the icon should stay:

screenshot

I do feel, though, that the outlined icon alone still may be difficult to notice for those with poor vision. how would you feel about also making it a touch bigger, @Nerixyz ?:

screenshot

[jacob-thompson]

Could you experiment with a red outline around the pause icon (and no text)?

certainly pops out more since red is a hot color, but I just think it looks ugly:

red outline, no text

I feel it'd look especially ugly if the outline blended with chat elements such as red chatters' names

[pajlada]

To confirm previous feedback, position shouldn't change with this PR but feel free to experiment more what makes it pop out and isn't ugly

[Nerixyz]

I think if anything the icon should stay:

Oh, sorry for the confusion. I meant that the icon should stay, but the text should only say paused.

I do feel, though, that the outlined icon alone still may be difficult to notice for those with poor vision.

What about adding a background similar to the tooltip, and possibly making the pause icon lighter? If we do that, we can ensure sufficient contrast on both light and dark themes:

(should probably be smaller and the lighter color shouldn't be #ffffff)

[jacob-thompson]

What about adding a background similar to the tooltip, and possibly making the pause icon lighter? If we do that, we can ensure sufficient contrast on both light and dark themes

I feel this looks nice:

dark theme screenshot

light theme screenshot

in this case the icon & text are #B4B4B4

[pajlada]

Not part of your changes, but the Pause icon does not handle different zoom levels well.
Would you like to fix that in this PR?

[jacob-thompson]

Not part of your changes, but the Pause icon does not handle different zoom levels well. Would you like to fix that in this PR?

fixed

[pajlada]

Looks good, thank you!