Repository navigation
chore(conan): don't create CMakeUserPresets.json - #6117
Merged
Merged
Conversation
pajlada
approved these changes
Mar 27, 2025
pajlada
left a comment
pajlada
left a comment
Member
There was a problem hiding this comment.
works for me and makes no difference for my windows build process
babicekmarek
pushed a commit
to babicekmarek/streamally-chatterino
that referenced
this pull request
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was building with VisualStudio recently and used CMakePresets, but it conflicted with conan, because conan would create
CMakeUserPresets.jsonwhich confused VS. The file that conan generates isn't useful.I should revise the documentation for builds on Windows and add at least a small section about VS and CMakePresets, because with cmake-conan, they're nice to use and will result in a vcpkg-like experience in VS.