Skip to content

refactor(notifications): remove platform specifier - #5914

Merged
pajlada merged 7 commits into
Chatterino:masterfrom
apa420:chore/remove-notification-platform
Feb 9, 2025
Merged

pajlada merged 7 commits into
Chatterino:masterfrom
apa420:chore/remove-notification-platform

Conversation

@apa420

@apa420 apa420 commented Feb 7, 2025

Copy link
Copy Markdown
Collaborator

Remove unused platform specifier that isn't used. We can only create toasts for a TwitchChannel so this is not necessary.

if (showNotification &&
this->isChannelNotified(payload.channelName, Platform::Twitch))

@pajlada

pajlada commented Feb 7, 2025

Copy link
Copy Markdown
Member

Waiting until after #5881 to merge this in

@pajlada

pajlada commented Feb 8, 2025

Copy link
Copy Markdown
Member

I can review this now when the merge conflicts have been fixed

@pajlada pajlada changed the title Chore: Remove unused platform specifier in toasts refactor(notifications): remove platform specifier Feb 9, 2025
@pajlada
pajlada enabled auto-merge (squash) February 9, 2025 11:25
@pajlada
pajlada merged commit 7dad35b into Chatterino:master Feb 9, 2025
babicekmarek pushed a commit to babicekmarek/streamally-chatterino that referenced this pull request Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants