Repository navigation
Disable QT keywords to avoid clashes with other libraries. - #5882
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Nerixyz
reviewed
Feb 2, 2025
Nerixyz
left a comment
Nerixyz
left a comment
Contributor
There was a problem hiding this comment.
Thank you, now we can use emit, slots, and signals in member names! 🎉
pajlada
approved these changes
Feb 2, 2025
pajlada
enabled auto-merge (squash)
February 2, 2025 09:38
babicekmarek
pushed a commit
to babicekmarek/streamally-chatterino
that referenced
this pull request
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to add libnotify support in #5881, QT keywords conflict with glib and other libraries so try disabling them.
Not sure what the feeling is on including/excluding
emitand not using keywords. It avoids some ugliness having to undef things and redef them 🙂