Skip to content

fix(luals-meta): generate globals in c2 and echo @lua commands - #5385

Merged
Mm2PL merged 6 commits into
Chatterino:masterfrom
Nerixyz:fix/more-luals-fixes
May 22, 2024
Merged

Mm2PL merged 6 commits into
Chatterino:masterfrom
Nerixyz:fix/more-luals-fixes

Conversation

@Nerixyz

@Nerixyz Nerixyz commented May 7, 2024

Copy link
Copy Markdown
Contributor

Based on changes in #5383, I noticed the enums weren't in the c2 global and nested structs weren't supported. This PR applies the fix from #5383 and moves everything we declare into the c2 global. The rule of thumb is: everything that gets a declaration in the metadata should be prefixed with c2 (→ "interfaces" i.e. classes without functions don't have to be in c2).

@Mm2PL
Mm2PL merged commit ec6b1ef into Chatterino:master May 22, 2024
@Nerixyz
Nerixyz deleted the fix/more-luals-fixes branch May 22, 2024 13:33
babicekmarek pushed a commit to babicekmarek/streamally-chatterino that referenced this pull request Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants