Skip to content

Release plugins alpha - #5288

Merged
Mm2PL merged 8 commits into
masterfrom
chore/plugins-public-alpha-release
May 6, 2024
Merged

Mm2PL merged 8 commits into
masterfrom
chore/plugins-public-alpha-release

Conversation

@Mm2PL

@Mm2PL Mm2PL commented Mar 31, 2024 •

Copy link
Copy Markdown
Collaborator

Adds a scary label and renames plugins from EXPERIMENTAL to alpha and enables them on normal builds. Things to do around merge:

  • Rename the plugins label
  • I'd really like someone to look more carefully at the plugins code. I hope I didn't make any security mistakes in that code. Anyone is more than welcome to submit feedback about this code here.

@Mm2PL Mm2PL added the Feature: Plugins Stuff related to our experimental Lua plugin support label Mar 31, 2024
@Mm2PL Mm2PL added this to the Post-2.5.0 milestone Mar 31, 2024
@Nerixyz

Nerixyz commented Mar 31, 2024

Copy link
Copy Markdown
Contributor

Btw, plugins are already enabled on the Ubuntu builds:

- os: ubuntu-20.04
container: ghcr.io/chatterino/chatterino2-build-ubuntu-20.04:latest
qt-version: 6.6.1
force-lto: false
plugins: true
skip-artifact: false
skip-crashpad: false
build-appimage: false
build-deb: true
- os: ubuntu-22.04
container: ghcr.io/chatterino/chatterino2-build-ubuntu-22.04:latest
qt-version: 6.6.1
force-lto: false
plugins: true
skip-artifact: false
skip-crashpad: false
build-appimage: true
build-deb: true

@Mm2PL
Mm2PL requested a review from pajlada April 4, 2024 00:38

@pajlada pajlada left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave CHATTERINO_PLUGINS off by default in the CMakeLists.txt, but enable it in our CI, move the changelog up (to the new unversioned category after merging), then I'm good to have this merged

@Mm2PL
Mm2PL enabled auto-merge (squash) May 6, 2024 14:55
@Mm2PL
Mm2PL merged commit 321d881 into master May 6, 2024
@Mm2PL
Mm2PL deleted the chore/plugins-public-alpha-release branch May 6, 2024 15:03
Mm2PL added a commit that referenced this pull request May 6, 2024
babicekmarek pushed a commit to babicekmarek/streamally-chatterino that referenced this pull request Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Plugins Stuff related to our experimental Lua plugin support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants