Skip to content

Implement C# 8.0 nullable standard #15

Closed

Description

@jennyf19

from Sujay V. Sarma (@sujayvsarma) and copied from Azure-Samples/active-directory-aspnetcore-webapp-openidconnect-v2#249

Even if the project is not C# 8.0, consider implementing the nullable standard by suffixing ? to all parameters and returns that may be NULL.

This will be a breaking changing internal to the library & to consuming code. Therefore, consider publishing the changes only during a major cycle.

Activity

  1. bgavrilMS commented on Feb 18, 2020

    @bgavrilMS
    Member

    That would be very cool indeed and the best time to do it is before releasing. Happy to help with this one, should not be too hard.

    This blog describes the feature better https://devblogs.microsoft.com/dotnet/embracing-nullable-reference-types/

    To quote from the blog:

    Libraries can accurately describe the null behavior of the APIs, in a way that is checkable in client code at the call site. This raises expressiveness on API boundaries so that everyone can get a handle on the safe propagation and dereferencing of nulls. Nobody likes null reference exceptions or argument-null exceptions! This helps you write the code right the first time, and avoid the sources of those exceptions before you even compile and run the code.

  2. added this to the 0.2.0-preview milestone on May 22, 2020
  3. jennyf19 commented on Jun 5, 2020

    @jennyf19
    CollaboratorAuthor

    Bogdan Gavril (@bgavrilMS) or Peter (@pmaytak) can you put this in the correct milestone please? not a breaking change. thx

  4. jmprieur commented on Jun 10, 2020

    @jmprieur
    Collaborator

    Bogdan Gavril (@bgavrilMS) jennyf19 Peter (@pmaytak) henrikm (@henrik-me)
    Talking with the ASP.NET Core team, ASP.NET Core 5 will support the nullable types.
    BTW Barry mentioned the this is causing issues to ASP.NET Core : dotnet/aspnetcore#22656

  5. jennyf19 commented on Jul 13, 2020

    @jennyf19
    CollaboratorAuthor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions