Repository navigation
Properly throw MsalServiceError exception - #820
Merged
Merged
Conversation
Avery-Dunn
reviewed
May 15, 2025
Avery-Dunn
approved these changes
May 15, 2025
Gladwin Johnson VR (gladjohn)
approved these changes
May 15, 2025
Ray Luo (rayluo)
force-pushed
the
raise-for-status
branch
from
May 15, 2025 23:36
3390e8c to
62855d4
Compare
Neha Bhargava (neha-bhargava)
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSAL Python defined a
MsalServiceErrorexception for years but did not actually use/throw it, until recently. This PR refactors the usage of this exception so that it is used properly. Comes with test cases.