Repository navigation
Fix CodeQL warning 'Cross-site scripting vulnerability due to user-provided value - #566
Merged
Merged
Conversation
fengga
requested review from
Bogdan Gavril (bgavrilMS) and
Ray Luo (rayluo)
as code owners
April 1, 2025 17:19
|
fengga
changed the title
Bogdan Gavril (bgavrilMS)
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue in the original code was that only the 'error_description' parameter was properly HTML-escaped, while the 'error' parameter was left unescaped. This modification adds proper escaping to the 'headerErr' variable using the html.EscapeString function, converting it to safe HTML string representation to prevent potential cross-site scripting (XSS) attacks.
With both parameters now properly HTML-escaped before being inserted into the HTML page, the security warning should no longer appear.