✨ อัปเดตล่าสุด: Azure/sonic buildimage/pull/

geans-pin · 2021-05-04T00:38:27Z

What I did
This PR is a resubmit of PR#3778

How I did it
The PDE silicon test harness and platform test harness can be found in
src/sonic-platform-pdk-pde

How to verify it
You must have both this PR and PR below.
sonic-net/sonic-platform-pdk-pde#28

Enable PDE by un-commenting line in rules/config
INCLUDE_PDE=y

Currently only Broadcom support has been added.

Description for the changelog
Adding support for Platform Development Environment (PDE)

lgtm-com · 2021-05-04T01:11:07Z

This pull request introduces 4 alerts when merging 138a7fe41449ce3814d5f85e260ba542eacf3091 into b2286a2 - view on LGTM.com

new alerts:

4 for Unused import

…submit PR#3778)

lgtm-com · 2021-05-05T02:36:19Z

This pull request introduces 4 alerts when merging c152419 into 0bc0f98 - view on LGTM.com

new alerts:

4 for Unused import

azure-pipelines · 2021-05-05T21:52:37Z

Commenter does not have sufficient privileges for PR 7510 in repo Azure/sonic-buildimage

adyeung · 2021-05-26T21:15:01Z

@jleveque Pls help review

…submit PR#3778)

…mage into pde_infra

lgtm-com · 2021-05-27T02:24:20Z

This pull request introduces 4 alerts when merging 1945c12 into 2cd61bc - view on LGTM.com

new alerts:

4 for Unused import

…mage into pde_infra

lgtm-com · 2021-05-27T13:47:36Z

This pull request introduces 4 alerts when merging 38592f9 into 237849a - view on LGTM.com

new alerts:

4 for Unused import

lgtm-com · 2021-06-05T00:01:07Z

This pull request introduces 4 alerts when merging d0f6bb2 into 1a3cab4 - view on LGTM.com

new alerts:

4 for Unused import

geans-pin · 2021-06-05T09:23:04Z

jleveque,

I have fixed the review comment. However, the kvm test is fail in the checker which seems not related with the fix.
Can you re-run the pipeline build ?

Geans

geans-pin · 2021-06-05T09:23:51Z

/azure-pipelines

geans-pin · 2021-06-09T01:49:12Z

/azpw run

mssonicbld · 2021-06-09T01:49:13Z

/AzurePipelines run

azure-pipelines · 2021-06-09T01:49:29Z

Azure Pipelines successfully started running 1 pipeline(s).

geans-pin · 2021-06-09T06:06:50Z

/azpw run

mssonicbld · 2021-06-09T06:06:51Z

/AzurePipelines run

azure-pipelines · 2021-06-09T06:07:09Z

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft · 2021-07-02T14:00:45Z

Sorry for misleading. I notice an unexpected file src/sonic-platform-pde/.gitkeep
Please double check the page https://git-scm.com/book/en/v2/Git-Tools-Submodules

In reply to: 873021616

geans-pin · 2021-07-02T22:54:46Z

Thanks qiluo, Here we are.. Just committed the fix

qiluo-msft

The submodule looks good now. Please check with other reviewers.

geans-pin · 2021-07-05T05:38:07Z

xumia, jleveque, lguohan,

All of the reviewed comments are fixed and build are Pass.
Are we ready for the merge ?

Geans

anshuv-mfst · 2021-07-07T21:23:23Z

Hi @xumia , @qiluo-msft - can you please approve and merge by/before 7/9, this PR is needed in 202106 release.

adyeung · 2021-07-22T22:23:22Z

@xumia, @qiluo-msft, @lguohan, @anshuv-mfst, pls help approve and merge

geans-pin · 2021-07-23T15:22:01Z

/azpw run

mssonicbld · 2021-07-23T15:22:02Z

/AzurePipelines run

azure-pipelines · 2021-07-23T15:22:21Z

Azure Pipelines successfully started running 1 pipeline(s).

lguohan

The PDE silicon test harness and platform test harness can be found in src/sonic-platform-pdk-pde

MikeHcChen · 2022-01-18T10:48:38Z

Recently, I tried to build PDE environment with 202111 branch codes.
I added "INCLUDE_PDE = y" and "PDDF_SUPPORT = y" in "sonic-buildimage/rules/config" file and
revised "sonic-buildimage/dockers/docker-pde/Dockerfile.j2" as following:
--- a/dockers/docker-pde/Dockerfile.j2
+++ b/dockers/docker-pde/Dockerfile.j2
@@ -1,4 +1,4 @@
-FROM {{ docker_pde_load_image }}
+FROM docker-config-engine-buster

Then I tried to build PDE using commands "make init;make configure PLATFORM=broadcom; make target/sonic-broadcom-pde.bin". I found I can get docker-pde.gz (PDE docker) and sonic-platform-pde_1.0_amd64.deb, but cannot get sonic-broadcom-pde.bin. The error logs like:

make: *** No rule to make target 'target/sonic-broadcom-pde.bin'. Stop.
Makefile.work:304: recipe for target 'target/sonic-broadcom-pde.bin' failed
make[1]: *** [target/sonic-broadcom-pde.bin] Error 2
make[1]: Leaving directory '/home/mike/sonic_202111_branch/sonic-buildimage'
Makefile:30: recipe for target 'target/sonic-broadcom-pde.bin' failed
make: *** [target/sonic-broadcom-pde.bin] Error 2

Is there anything I should add to make the PDE image in SONiC?
Any idea is welcome. Thanks.

geans-pin requested review from lguohan, qiluo-msft and xumia as code owners May 4, 2021 00:38

xumia reviewed May 5, 2021

View reviewed changes

Comment thread Makefile.work Outdated

Initial commit for introducing the SONiC Platform Development Env (Re…

c152419

…submit PR#3778)

adyeung mentioned this pull request May 26, 2021

Initial commit for introducing the SONiC Platform Development Environ… #3778

Closed

jleveque reviewed May 27, 2021

View reviewed changes

Comment thread Makefile.work Outdated

geans-pin added 2 commits May 26, 2021 18:52

Initial commit for introducing the SONiC Platform Development Env (Re…

de606bb

…submit PR#3778)

Merge branch 'pde_infra' of https://github.com/geans-pin/sonic-buildi…

1945c12

…mage into pde_infra

geans-pin added 2 commits May 27, 2021 05:46

Fix conflict

18c82ae

Merge branch 'pde_infra' of https://github.com/geans-pin/sonic-buildi…

38592f9

…mage into pde_infra

jleveque suggested changes Jun 4, 2021

View reviewed changes

Fix review comment

d0f6bb2

geans-pin requested review from jleveque and xumia June 5, 2021 13:34

fix submodule add

fbd5f24

qiluo-msft reviewed Jul 4, 2021

View reviewed changes

lguohan reviewed Jul 23, 2021

View reviewed changes

Comment thread rules/config Outdated

lguohan reviewed Jul 23, 2021

View reviewed changes

Comment thread platform/broadcom/one-pde-image.mk Outdated

lguohan reviewed Jul 23, 2021

View reviewed changes

Comment thread slave.mk Outdated

lguohan reviewed Jul 23, 2021

View reviewed changes

Comment thread slave.mk Outdated

lguohan reviewed Jul 23, 2021

View reviewed changes

Comment thread Makefile.work Outdated

qiluo-msft reviewed Jul 23, 2021

View reviewed changes

Comment thread platform/broadcom/one-pde-image.mk Outdated

geans-pin added 2 commits July 22, 2021 23:56

Fix review comment

e4cff3e

Fix build err

9ed8ebb

qiluo-msft reviewed Jul 23, 2021

View reviewed changes

Comment thread Makefile.work Outdated

Removed unused

c79d04d

lguohan reviewed Jul 23, 2021

View reviewed changes

Comment thread Makefile.work Outdated

lguohan reviewed Jul 23, 2021

View reviewed changes

Comment thread slave.mk Outdated

lguohan reviewed Jul 23, 2021

View reviewed changes

Comment thread slave.mk Outdated

Fix comment 2nd

7895160

lguohan approved these changes Jul 23, 2021

View reviewed changes

lguohan merged commit aa59bfe into sonic-net:master Jul 24, 2021

carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021

[PDE]: introduce the SONiC Platform Development Env (sonic-net#7510)

4fe7979

The PDE silicon test harness and platform test harness can be found in src/sonic-platform-pdk-pde

Conversation

geans-pin commented May 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgtm-com Bot commented May 4, 2021

Uh oh!

Uh oh!

lgtm-com Bot commented May 5, 2021

Uh oh!

azure-pipelines Bot commented May 5, 2021

Uh oh!

adyeung commented May 26, 2021

Uh oh!

Uh oh!

lgtm-com Bot commented May 27, 2021

Uh oh!

lgtm-com Bot commented May 27, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lgtm-com Bot commented Jun 5, 2021

Uh oh!

geans-pin commented Jun 5, 2021

Uh oh!

geans-pin commented Jun 5, 2021

Uh oh!

geans-pin commented Jun 9, 2021

Uh oh!

mssonicbld commented Jun 9, 2021

Uh oh!

azure-pipelines Bot commented Jun 9, 2021

Uh oh!

geans-pin commented Jun 9, 2021

Uh oh!

mssonicbld commented Jun 9, 2021

Uh oh!

azure-pipelines Bot commented Jun 9, 2021

Uh oh!

qiluo-msft commented Jul 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geans-pin commented Jul 2, 2021

Uh oh!

qiluo-msft left a comment

Choose a reason for hiding this comment

Uh oh!

geans-pin commented Jul 5, 2021

Uh oh!

anshuv-mfst commented Jul 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adyeung commented Jul 22, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

geans-pin commented Jul 23, 2021

Uh oh!

mssonicbld commented Jul 23, 2021

Uh oh!

azure-pipelines Bot commented Jul 23, 2021

Uh oh!

lguohan left a comment

Choose a reason for hiding this comment

Uh oh!

MikeHcChen commented Jan 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

geans-pin commented May 4, 2021 •

edited

Loading

qiluo-msft commented Jul 2, 2021 •

edited

Loading

anshuv-mfst commented Jul 7, 2021 •

edited

Loading

MikeHcChen commented Jan 18, 2022 •

edited

Loading