Repository navigation
fix: require Machine API for Windows NodeClasses - #1927
Merged
Robin D. (comtalyst) merged 1 commit intoOct 8, 2026
Conversation
Robin D. (comtalyst)
force-pushed
the
robin/task10204-require-machine-api-windows-20260919
branch
from
September 19, 2026 09:58
0792fac to
ecde242
Compare
1 of 3 tasks
Robin D. (comtalyst)
force-pushed
the
robin/task10204-require-machine-api-windows-20260919
branch
from
September 19, 2026 14:50
ecde242 to
306e8c6
Compare
Robin D. (comtalyst)
force-pushed
the
robin/task10204-require-machine-api-windows-20260919
branch
from
September 19, 2026 18:32
306e8c6 to
867a1f1
Compare
Robin D. (comtalyst)
force-pushed
the
robin/task10204-require-machine-api-windows-20260919
branch
from
September 19, 2026 19:45
867a1f1 to
55fd0e6
Compare
Robin D. (comtalyst)
force-pushed
the
robin/task10204-require-machine-api-windows-20260919
branch
from
October 6, 2026 07:04
55fd0e6 to
4506738
Compare
Robin D. (comtalyst)
force-pushed
the
robin/task10204-require-machine-api-windows-20260919
branch
from
October 6, 2026 07:41
4506738 to
5f04de2
Compare
Robin D. (comtalyst)
force-pushed
the
robin/task10204-require-machine-api-windows-20260919
branch
from
October 7, 2026 21:21
5f04de2 to
6f3533e
Compare
Robin D. (comtalyst)
force-pushed
the
robin/task10204-require-machine-api-windows-20260919
branch
from
October 7, 2026 22:24
6f3533e to
5517ad1
Compare
Robin D. (comtalyst)
marked this pull request as ready for review
October 7, 2026 22:45
Contributor
There was a problem hiding this comment.
ðĒ Approval recommended
The validation correctly recognizes both Machine API modes and includes comprehensive regression coverage.
0 open findings
What changed in this PR
Requires Windows AKSNodeClasses to use an AKS Machine API provisioning mode while preserving Linux behavior.
Changes:
- Rejects Windows NodeClasses in VM-based modes.
- Accepts both AKS Machine API modes.
- Adds coverage for Windows and Linux mode compatibility.
| File | Description |
|---|---|
pkg/âcontrollers/ânodeclass/âstatus/âvalidation.go |
Adds Windows provisioning-mode validation. |
pkg/âcontrollers/ânodeclass/âstatus/âvalidation_test.go |
Tests supported and unsupported mode combinations. |
ð§ Review effort: Balanced
ðĄ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Robin D. (comtalyst)
force-pushed
the
robin/task10204-require-machine-api-windows-20260919
branch
from
October 7, 2026 23:39
5517ad1 to
db9281e
Compare
Robin D. (comtalyst)
force-pushed
the
robin/task10204-require-machine-api-windows-20260919
branch
2 times, most recently
from
October 8, 2026 00:16
23c1833 to
1f365f9
Compare
1 of 3 tasks
Matthew Christopher (matthchr)
approved these changes
Oct 8, 2026
Co-Authored-By: Claude <noreply@anthropic.com>
Robin D. (comtalyst)
force-pushed
the
robin/task10204-require-machine-api-windows-20260919
branch
from
October 8, 2026 18:36
1f365f9 to
7405aaf
Compare
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Require AKS Machine API provisioning for Windows AKSNodeClasses. Both aksmachineapi and aksmachineapiheaderbatch are accepted; VM-based provisioning modes fail validation. Linux behavior is unchanged.
Stacked on #1926.
How was this change tested?
Does this change impact docs?
Release Note