Repository navigation
Concurrent Health Checks - #40588
Merged
Tomas Varon (tvaron3) merged 9 commits intoApr 18, 2025
Merged
Concurrent Health Checks #40588
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
sdk/cosmos/azure-cosmos/azure/cosmos/_location_cache.py:428
- Calling union on the 'health_check_endpoints' set does not modify the set in-place; consider using 'update' or reassigning the result to ensure that endpoints from both read and write contexts are included.
health_check_endpoints.union(_get_health_check_endpoints(
Collaborator
|
API change check API changes are not detected in this pull request. |
Member
Author
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…into tvaron3/concurrentHealthChecks
…varon3/azure-sdk-for-python into tvaron3/concurrentHealthChecks
Simon Moreno (simorenoh)
approved these changes
Apr 18, 2025
Simon Moreno (simorenoh)
left a comment
Simon Moreno (simorenoh)
left a comment
Member
There was a problem hiding this comment.
changes lgtm - let's just make sure the relevant failing health check tests are working as intended
Kushagra Thapar (kushagraThapar)
approved these changes
Apr 18, 2025
Kushagra Thapar (kushagraThapar)
left a comment
Kushagra Thapar (kushagraThapar)
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks Tomas Varon (@tvaron3)
Rena (cRui861)
pushed a commit
that referenced
this pull request
May 14, 2025
* concurrent health checks * update changelog * add test, fix bug, update changelog * fix tests * fix tests * fix tests * fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description