Repository navigation
preventing SyncTriggers on placeholder hosts - #11874
Merged
Brett Samblanet (brettsam) merged 3 commits intoJul 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents SyncTriggers from publishing placeholder-host trigger metadata (notably the WarmUp function) during the specialization window where placeholder mode has been cleared but the active host is still running the standby configuration, addressing the race described in #11873.
Changes:
- Add a guard in
FunctionsSyncManager.TrySyncTriggersAsyncto skip syncing when the active host is still in standby configuration. - Add an integration test validating that a placeholder-only
WarmUppayload is not published. - Add an E2E test reproducing the specialization window and asserting
WarmUpis not published.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/WebJobs.Script.WebHost/Management/FunctionsSyncManager.cs | Adds standby-host detection to prevent publishing placeholder triggers during specialization windows. |
| test/WebJobs.Script.Tests.Integration/Management/FunctionsSyncManagerTests.cs | Adds an integration test ensuring placeholder WarmUp trigger payload is not published. |
| test/WebJobs.Script.Tests.Integration/WebHostEndToEnd/SpecializationE2ETests.cs | Adds an E2E repro for the specialization race window and validates WarmUp isn’t published. |
Brett Samblanet (brettsam)
requested review from
Jacob Viau (jviau),
Shyju Krishnankutty (kshyju) and
Mathew Charles (mathewc)
July 16, 2026 15:44
Jacob Viau (jviau)
approved these changes
Jul 16, 2026
Fabio Cavalcante (fabiocav)
approved these changes
Jul 16, 2026
Fabio Cavalcante (fabiocav)
left a comment
Member
There was a problem hiding this comment.
Approving, but left a comment and I think a follow up is required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11873
Certain flows (namely worker specialization failures) could result in a SyncTriggers call being made against a placeholder host. This would result in a Warmup function being sent to the platform and could cause issues with scaling and metadata.
This change checks whether the current host is a placeholder and if so, skip the sync. Previous behavior checked if the environment was a placeholder but did not validate the active host.
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.md