Skip to content

Return or log exception if publishednodes.json file is not writable #2195

Closed

Description

Is your feature request related to a problem? Please describe.
The logs are not providing any warning nor error when json containing published nodes from opc publisher is not writable and only indicator is response 500 with null payload. This could lead in long debugging time to find source of problem.

Describe the solution you'd like
Logs should raise that published nodes file is not writable or at least 500 return payload should clearly state the problem.

Additional context
image
-> Additionally no warning and errors inside logs of OPC publisher module. Logs were stating that everything went fine. Log level of OPC publisher was debug.

In our case the file was owned by Root (read and write for root but readable for all users) while module was running asp app user.

Thank you for developing this great tool.

Activity

  1. marcschier commented on Feb 24, 2024

    @marcschier
    Collaborator

    Thanks 👍. Surprising that file write errors are not logged. I will make sure that errors are logged. What we can do about response code I need to see since the service is decoupled from persisting.

  2. marcschier commented on Jun 18, 2024

    @marcschier
    Collaborator

    This is now fixed. The exception message is now the payload returned plus a status code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions