Fix X11 active window tracking - #21846
Merged
Merged
Conversation
MrJul
added
area-x11
backport-candidate-12.1.x
|
You can test this PR using the following package version. |
miloush
added
the
backport-candidate-11.3.x
MrJul
pushed a commit
that referenced
this pull request
Jul 29, 2026
* Force-mark closed window as no longer active if backend didn't do it for some reason * [X11] Speculatively mark the active closed dialog parent as active window
MrJul
added
backported-12.1.x
and removed
backport-candidate-12.1.x
MrJul
pushed a commit
that referenced
this pull request
Aug 5, 2026
* Force-mark closed window as no longer active if backend didn't do it for some reason * [X11] Speculatively mark the active closed dialog parent as active window
MrJul
added
backported-11.3.x
and removed
backport-candidate-11.3.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This masks disparity between X11 and win32/macos backends. Unlike those window activation arrives asynchronously, when dialog gets closed its parent doesn't become active window immediately.
So in modes where we can reliably track current active window, we speculatively mark the parent as new active window. If another window becomes active, it auto-corrects on the next _NET_ACTIVE_WINDOW property change (which is bound to arrive since we just closed the current active window).
The PR also addresses window.IsActive staying true after window got closed if backend haven't triggered deactivation event for some reason
Fixes #21841