Keep page in NavigationPage's logical tree until animation is complete - #21751
Merged
Conversation
MrJul
added
bug
backport-candidate-12.1.x
This was referenced Jul 10, 2026
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Jul 11, 2026
MrJul
added a commit
that referenced
this pull request
Jul 29, 2026
#21751) * Keep page in NavigationPage's logical tree until animation is complete * Share templates in NavigationPageTests
MrJul
added
backported-12.1.x
and removed
backport-candidate-12.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes
NavigationPage,which was removing the page it's transitioning away from the logical tree, causing visible issues such as unapplied styles and broken bindings briefly visible during the transition. Worse, it caused issues such as #21737, where every item in aListBoxwas measured with a 0 height (due to the content presenter being empty), causing the viewport to be able to incorrectly contain everything, breaking virtualization.The page is now kept in the logical tree until the transition is complete.
Unit tests have been added.
Fixed issues