Fix AutoCompleteBox popup not closing on focus lost - #21749
Merged
Conversation
MrJul
added
bug
backport-candidate-12.1.x
3 tasks
timunie
approved these changes
Jul 10, 2026
timunie
left a comment
timunie
left a comment
Collaborator
There was a problem hiding this comment.
Looks much better now overall.
|
You can test this PR using the following package version. |
MrJul
added a commit
that referenced
this pull request
Jul 29, 2026
* Add failing test for AutoCompleteBox * Fix AutoCompleteBox popup not closing on focus lost
MrJul
added
backported-12.1.x
and removed
backport-candidate-12.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR makes sure that the popup of an
AutoCompleteBoxcloses when it loses focus.A unit test has been added.
What is the current behavior?
The popup stays open after losing the focus.
What is the updated/expected behavior with this PR?
The popup correctly closes.
How was the solution implemented (if it's not obvious)?
AutoCompleteBoxhad a lot of convoluted code and comments dating back 8+ years regarding focus management that are no longer accurate. With the recent changes in focus management in Avalonia 12, the code was just wrong.GotFocus/LostFocusare now the sources of truth, matchingTextBoxandComboBox.